Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#75 : 2nd qa #76

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Feature/#75 : 2nd qa #76

merged 9 commits into from
Sep 6, 2024

Conversation

Eonji-sw
Copy link
Member

@Eonji-sw Eonji-sw commented Sep 6, 2024 •
edited
Loading

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” ํ•„์ˆ˜๋กœ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • notification patch ์ˆ˜์ •
  • notification item UI detail ์ˆ˜์ •
  • posting back dialog ์กฐ๊ฑด ์ถ”๊ฐ€
  • posting editText maxLen ํ†ตํ•ฉ ์ˆ˜์ •
  • posting len string UI ์ˆ˜์ •
  • posting ๊ฐค๋Ÿฌ๋ฆฌ ๊ถŒํ•œ ์ฝ”๋“œ ์ œ๊ฑฐ

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

2024-09-06.8.19.20.mov

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

@Eonji-sw Eonji-sw added โœ…ย [MOD] ์ฝ”๋“œ ์ˆ˜์ • ๋ฐ ๋‚ด๋ถ€ ํŒŒ์ผ ์ˆ˜์ • ๐Ÿ”จย [FIX] ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ๋ฐ ํ•ด๊ฒฐ ย โ™ป๏ธย [REFACTOR] ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง ๐Ÿฐ ์–ธ์ง€ ๋จผ์ง€ labels Sep 6, 2024
@Eonji-sw Eonji-sw self-assigned this Sep 6, 2024
sohyun127
sohyun127 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@sohyun127 sohyun127 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTTM ๊ทผ๋ฐ ๋…ธํ‹ฐ ํ”„๋กœํ•„ ์‚ฌ์ง„ android:scaleType="centerCrop" ์ ์šฉ ์•ˆ๋œ ๊ฑฐ ๊ฐ™์€๋”” ํ™•์ธํ•ด์ฃผ์„ธ์š”!

@Eonji-sw Eonji-sw merged commit f7a5095 into develop Sep 6, 2024
1 check passed
@Eonji-sw Eonji-sw deleted the feature/#75-2nd-qa branch September 6, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohyun127 sohyun127 sohyun127 approved these changes

@chanubc chanubc Awaiting requested review from chanubc

Assignees

@Eonji-sw Eonji-sw

Labels
๐Ÿ”จย [FIX] ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ๋ฐ ํ•ด๊ฒฐ โœ…ย [MOD] ์ฝ”๋“œ ์ˆ˜์ • ๋ฐ ๋‚ด๋ถ€ ํŒŒ์ผ ์ˆ˜์ • ย โ™ป๏ธย [REFACTOR] ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง ๐Ÿฐ ์–ธ์ง€ ๋จผ์ง€
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] : 2์ฐจ QA ๋ฐ˜์˜
2 participants
@Eonji-sw @sohyun127